Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update rules_lint #672

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(deps): update rules_lint #672

wants to merge 1 commit into from

Conversation

alexeagle
Copy link
Member

@alexeagle alexeagle commented Aug 14, 2024 •
edited
Loading

Also bazel run format

Changes are visible to end-users: no

Test plan

  • Covered by existing test cases

@aspect-workflows Aspect Workflows
Copy link

aspect-workflows bot commented Aug 14, 2024 •
edited
Loading

Test

All tests were cache hits

85 tests (100.0%) were fully cached saving 6s.

Buildifier      Format

gregmagolan
gregmagolan reviewed Aug 19, 2024
View reviewed changes
tools/format/BUILD.bazel

format_multirun(
name = "format",
shell = "@aspect_rules_lint//format:shfmt",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.bats tests are covered under shfmt?

@gregmagolan
Copy link
Member

Hmm. Why does bazel build //:format require a cc toolchain??

Auto-Configuration Error: Cannot find gcc or CC; either correct your path or set the CC environment variable
(02:42:38) ERROR: /mnt/ephemeral/output/rules_ts/__main__/external/bazel_tools/src/tools/launcher/BUILD:10:14: @@bazel_tools//src/tools/launcher:launcher depends on @@bazel_tools~cc_configure_extension~local_config_cc//:cc-compiler-k8 in repository @@bazel_tools~cc_configure_extension~local_config_cc which failed to fetch. no such package '@@bazel_tools~cc_configure_extension~local_config_cc//': 
Auto-Configuration Error: Cannot find gcc or CC; either correct your path or set the CC environment variable
(02:42:42) ERROR: /mnt/ephemeral/output/rules_ts/__main__/external/rules_multirun~/internal/BUILD:4:10: @@rules_multirun~//internal:multirun depends on @@bazel_tools~cc_configure_extension~local_config_cc//:cc-compiler-k8 in repository @@bazel_tools~cc_configure_extension~local_config_cc which failed to fetch. no such package '@@bazel_tools~cc_configure_extension~local_config_cc//': 
Auto-Configuration Error: Cannot find gcc or CC; either correct your path or set the CC environment variable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregmagolan gregmagolan gregmagolan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexeagle @gregmagolan